Skip to content

Conversation

@salmart-dev
Copy link
Contributor

@salmart-dev salmart-dev commented Nov 19, 2025

Summary

This branch contains changes related to implementing the path-based FS setup for MountProviders in apps shipped within the server.

The branch is part of this set of branches:

Mount Providers (internal & external apps)

Mount Provider Type Status
\OCA\Files_Sharing\MountProvider Internal In progress
\OCA\Files_Sharing\External\MountProvider Internal In progress
\OCA\Files_External\Config\ConfigAdapter Internal Todo
\OCA\Circles\MountManager\CircleMountProvider External Todo
\OC\Files\Mount\CacheMountProvider Internal Skip?
\OCA\GroupFolders\Mount\MountProvider External Todo
\OCA\Collectives\Mount\MountProvider External Todo
\OCA\VirtualFolder\Mount\VirtualFolderMountProvider External Todo

TODO

  • Add PHPDocs for new interface methods
  • Check if the new interface methods can just be introduced or if another solution is needed (since providers not implementing the new changes would break)

Checklist

@salmart-dev salmart-dev self-assigned this Nov 19, 2025
@salmart-dev salmart-dev added the 2. developing Work in progress label Nov 19, 2025
@salmart-dev salmart-dev added this to the Nextcloud 33 milestone Nov 19, 2025
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch 2 times, most recently from ae0c613 to cdc7233 Compare November 20, 2025 16:38
@salmart-dev salmart-dev force-pushed the feature/54562/implement-setup-by-cache-mount-providers branch 2 times, most recently from 2dbca80 to 78fd4e6 Compare November 20, 2025 16:39
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch 2 times, most recently from 70b0ecc to b94b74f Compare November 20, 2025 17:23
@salmart-dev salmart-dev force-pushed the feature/54562/implement-setup-by-cache-mount-providers branch from 021a3a2 to ed9fdb2 Compare November 20, 2025 17:23
Signed-off-by: Salvatore Martire <[email protected]>
This commit adds a workaround to restore the functionality of apps that
rely on descending the file-tree to check for access permissions, like
files_accesscontrol. The navigation is done navigating the tree upwards,
from the target node, to the root node.

Signed-off-by: Salvatore Martire <[email protected]>
Signed-off-by: Salvatore Martire <[email protected]>
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from b94b74f to 7f26f7e Compare November 26, 2025 09:06
@salmart-dev salmart-dev force-pushed the feature/54562/implement-setup-by-cache-mount-providers branch from ed9fdb2 to 526dba0 Compare November 26, 2025 09:06
replace array_reduce + array_merge with array_merge(...)
replace conditional assignment with ??=

Signed-off-by: Salvatore Martire <[email protected]>
IMountProviders implementing this interface will be able to take
advantage of authoritative mounts.

The function `getMountsFromMountPoints` will receive the path that
the provider is asked to set-up and an array of IMountProviderArgs
providing information regarding the stored mount points and the
file cache data for the related root. The mount provider should verify
the validity of the mounts and return IMountPoints related to them.

Signed-off-by: Salvatore Martire <[email protected]>
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 7f26f7e to 6e43ef9 Compare November 27, 2025 14:07
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from c0c82fd to 2477163 Compare November 28, 2025 16:31
@salmart-dev salmart-dev force-pushed the feature/54562/implement-setup-by-cache-mount-providers branch from 526dba0 to 2bcf3a0 Compare November 28, 2025 16:33
@salmart-dev salmart-dev force-pushed the feature/54562/pathSpecificFSSetup branch from 2477163 to 24aff0e Compare December 4, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants